julien/apoena
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

update crc card article

Browse Source
This commit is contained in:
Julien Calixte
2022-12-20 22:57:07 +01:00
parent 68cba21b3f
commit 9a0ae14fc5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/pages/posts/crc-cards-as-training-material.mdx
View File

@@ -23,11 +23,11 @@ CRC cards are a great tool to focus the discussion and to aknowledge the fact th
## The horrible `UserBookmarks` component 😨 ## The horrible `UserBookmarks` component 😨
Disclaimer: we're about to look at a very ugly code that is definetely doing too many things, (FYI it is a simplified version of a component in one of my project). The purpose of the discussion I have is to show to the tech lead that we really want to prevent this to happen and it is her mission to standardize it with her team. We're about to look at a very ugly code that is definetely doing too many things. The purpose of the discussion I have is to show to the tech lead that we really want to prevent this to happen and it is her mission to standardize it with her team.
As the code does too many things, it can be hard to follow this post, but, I'll try my best to take you with me on this journey. As the code does too many things, it can be hard to follow this post, but, I'll try my best to take you with me on this journey.
Let's say we have a `UserBookmarks` component. Here is the `UserBookmarks` component:
```tsx ```tsx
interface Props { interface Props {
@@ -196,7 +196,9 @@ const tilesAnimation = gsap.to({
## Simplification ## Simplification
### <OrderTag order={1} /> only necessary property Once we said all that, let's relook our component.
### <OrderTag order={1} /> only necessary prop
```tsx ```tsx
interface Props { interface Props {