From 9a0ae14fc5344b6db42f92ee54fc9459c5afc329 Mon Sep 17 00:00:00 2001 From: Julien Calixte Date: Tue, 20 Dec 2022 22:57:07 +0100 Subject: [PATCH] update crc card article --- src/pages/posts/crc-cards-as-training-material.mdx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/pages/posts/crc-cards-as-training-material.mdx b/src/pages/posts/crc-cards-as-training-material.mdx index 0fa9e6f..f0f0f9f 100644 --- a/src/pages/posts/crc-cards-as-training-material.mdx +++ b/src/pages/posts/crc-cards-as-training-material.mdx @@ -23,11 +23,11 @@ CRC cards are a great tool to focus the discussion and to aknowledge the fact th ## The horrible `UserBookmarks` component 😨 -Disclaimer: we're about to look at a very ugly code that is definetely doing too many things, (FYI it is a simplified version of a component in one of my project). The purpose of the discussion I have is to show to the tech lead that we really want to prevent this to happen and it is her mission to standardize it with her team. +We're about to look at a very ugly code that is definetely doing too many things. The purpose of the discussion I have is to show to the tech lead that we really want to prevent this to happen and it is her mission to standardize it with her team. As the code does too many things, it can be hard to follow this post, but, I'll try my best to take you with me on this journey. -Let's say we have a `UserBookmarks` component. +Here is the `UserBookmarks` component: ```tsx interface Props { @@ -196,7 +196,9 @@ const tilesAnimation = gsap.to({ ## Simplification -### only necessary property +Once we said all that, let's relook our component. + +### only necessary prop ```tsx interface Props {