remanso-space/remanso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(repo): add Octokit request timeouts and retry UI

Browse Source 
Before, every GitHub call awaited indefinitely with no AbortSignal,
so a "lie-fi" connection (technically online, effectively dead) left
FluxNote stuck on the skeleton loader and the freshness badge spinning
forever. Inject an 8s AbortSignal.timeout via octokit.hook.before
(20s override on the recursive tree fetch), classify failures in the
userRepo store as auth vs network, and surface a "Couldn't reach
GitHub" retry button when no cached content is available.
This commit is contained in:
Julien Calixte
2026-05-16 23:28:11 +02:00
parent de7ac8d096
commit fc4ed188d7
5 changed files with 130 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/modules/repo/store/userRepo.store.ts
View File

@@ -14,6 +14,8 @@ import {
} from "@/modules/repo/services/repo"
import { refreshToken } from "@/modules/user/service/signIn"
export type RepoLoadError = "auth" | "network" | null
interface State {
user: string
repo: string
@@ -21,9 +23,20 @@ interface State {
readme?: string | null
userSettings?: UserSettings | null
needToLogin: boolean
loadError: RepoLoadError
_requestId: number
}
const classifyLoadError = (error: unknown): "auth" | "network" => {
if (error && typeof error === "object") {
const e = error as { name?: string; status?: number }
if (e.name === "TimeoutError" || e.name === "AbortError") return "network"
if (e.status === 401 || e.status === 403 || e.status === 404) return "auth"
if (typeof e.status === "number" && e.status >= 500) return "network"
}
return "network"
}
export const useUserRepoStore = defineStore("USER_REPO_STATE", {
state: (): State => ({
user: "",
@@ -32,6 +45,7 @@ export const useUserRepoStore = defineStore("USER_REPO_STATE", {
readme: undefined,
userSettings: undefined,
needToLogin: false,
loadError: null,
_requestId: 0
}),
actions: {
@@ -63,6 +77,7 @@ export const useUserRepoStore = defineStore("USER_REPO_STATE", {
const requestId = ++this._requestId
this.user = user
this.repo = repo
this.loadError = null
let lsLayout: Partial<UserSettings> = {}
try {
@@ -163,14 +178,29 @@ export const useUserRepoStore = defineStore("USER_REPO_STATE", {
_id: userSettingsId
})
})
.catch((error) => {
if (requestId !== this._requestId) return
console.warn("getFiles failed", error)
this.loadError = classifyLoadError(error)
})
getCachedMainReadme(user, repo).then(async (cachedReadme) => {
if (requestId !== this._requestId) return
if (cachedReadme) this.readme = cachedReadme
const fetched = await getMainReadme(user, repo)
if (requestId !== this._requestId) return
this.readme = fetched
})
getCachedMainReadme(user, repo)
.then(async (cachedReadme) => {
if (requestId !== this._requestId) return
if (cachedReadme) this.readme = cachedReadme
const fetched = await getMainReadme(user, repo)
if (requestId !== this._requestId) return
this.readme = fetched
})
.catch((error) => {
if (requestId !== this._requestId) return
console.warn("getMainReadme failed", error)
// Only surface the error UI if we have nothing cached to display.
if (!this.readme) {
this.readme = null
this.loadError = classifyLoadError(error)
}
})
},
addFile(file: RepoFile) {
if (!file.sha) {