From afc850a0b3841a4d96d15d8f11e49d27ccd256c4 Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Sun, 6 Aug 2023 22:16:57 +0200
Subject: [PATCH] fix github href

---
 src/App.vue                    | 12 ++++++++++--
 src/components/LoginGithub.vue |  7 +------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 0164ab2..be2b153 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -6,10 +6,18 @@ const { isReady } = useGitHubLogin()
 </script>
 
 <template>
-  <router-view v-if="isReady" />
-  <new-version />
+  <div id="main-app">
+    <router-view v-if="isReady" />
+    <new-version />
+  </div>
 </template>
 
 <style lang="scss">
 @import 'styles/app';
+
+#main-app {
+  height: 100vh;
+  display: flex;
+  flex: 1;
+}
 </style>
diff --git a/src/components/LoginGithub.vue b/src/components/LoginGithub.vue
index faee7cd..a1bfbb6 100644
--- a/src/components/LoginGithub.vue
+++ b/src/components/LoginGithub.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="login-github">
     <br />
-    <a ;href="url" target="_blank" rel="noopener noreferrer">
+    <a :href="url.toString()" target="_blank" rel="noopener noreferrer">
       login to
       <img src="@/assets/icons/github.svg" alt="GitHub icon" />
     </a>
@@ -25,8 +25,3 @@ export default defineComponent({
   }
 })
 </script>
-
-<style lang="scss" scoped>
-.login-github {
-}
-</style>