From 8d0d3dc7f9104b87eaafe0182c62a2d48557d55d Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Wed, 26 Jul 2023 21:49:09 +0200
Subject: [PATCH] add takt time and simplify simulation getters

---
 src/modules/feature/FeatureSteps.vue          | 29 ++----
 src/modules/feature/feature-board.ts          | 41 +++++---
 src/modules/feature/feature-store.ts          | 16 +++-
 .../simulation/SimulationDashboard.vue        | 60 +++++-------
 src/modules/simulation/simulation-store.ts    | 95 ++++++-------------
 src/store-type.ts                             |  3 +-
 6 files changed, 99 insertions(+), 145 deletions(-)

diff --git a/src/modules/feature/FeatureSteps.vue b/src/modules/feature/FeatureSteps.vue
index e796aab..b665be3 100644
--- a/src/modules/feature/FeatureSteps.vue
+++ b/src/modules/feature/FeatureSteps.vue
@@ -7,22 +7,6 @@ import { onMounted } from 'vue'
 const featureStore = useFeatureStore()
 
 onMounted(() => featureStore.initBoard())
-
-const pullAndProblemSolving20Percent = () => {
-  if (featureStore.meta.totalDays % 5 === 0) {
-    featureStore.nextDay('pull-dps')
-  } else {
-    featureStore.nextDay('pull')
-  }
-}
-
-const pushAndProblemSolving20Percent = () => {
-  if (featureStore.meta.totalDays % 5 === 0) {
-    featureStore.nextDay('push-dps')
-  } else {
-    featureStore.nextDay('push')
-  }
-}
 </script>
 
 <template>
@@ -31,17 +15,16 @@ const pushAndProblemSolving20Percent = () => {
       {{ featureStore.features.length }} features | mean complexity :
       {{ featureStore.meanComplexity }} | mean lead time :
       {{ featureStore.meanLeadTime }} days | Total days:
-      {{ featureStore.meta.totalDays }}
+      {{ featureStore.meta.totalDays }} | Team work experience:
+      {{ featureStore.meta.teamWorkExperience }}
     </div>
+    <div class="row">
+      New feature live every {{ featureStore.taktTime }} days.
+    </div>
+    <div class="row">Strategy of the day:</div>
     <div class="row">
       <button @click="featureStore.nextDay('push')">push system</button>
       <button @click="featureStore.nextDay('pull')">pull system</button>
-      <button @click="pushAndProblemSolving20Percent">
-        push and problem solving
-      </button>
-      <button @click="pullAndProblemSolving20Percent">
-        pull and problem solving
-      </button>
       <button @click="featureStore.nextDay('problem-solving')">
         problem solving
       </button>
diff --git a/src/modules/feature/feature-board.ts b/src/modules/feature/feature-board.ts
index 5d7a3bb..ddcdccb 100644
--- a/src/modules/feature/feature-board.ts
+++ b/src/modules/feature/feature-board.ts
@@ -3,7 +3,13 @@ import { FeatureStep } from '@/modules/feature/feature-steps'
 import { features as initialFeatures } from '@/modules/feature/feature.fixture'
 import { Strategy } from '@/modules/lean/strategy'
 import { FeatureState } from '@/store-type'
-import { getMean, pickRandomElement, popNElement, shuffleArray } from '@/utils'
+import {
+  getMean,
+  pickRandomElement,
+  popNElement,
+  shuffleArray,
+  sumElements
+} from '@/utils'
 
 const MAX_FEATURES = 200
 const HARD_STOP = 5000
@@ -11,15 +17,15 @@ const HARD_STOP = 5000
 const hasQualityIssue = ({
   complexity,
   tasksInParallel,
-  daysWithProblemSolving
+  teamWorkExperience
 }: {
   complexity: number
   tasksInParallel: number
-  daysWithProblemSolving: number
+  teamWorkExperience: number
 }): boolean => {
   const qualityProbability = getQualityProbability(
     complexity,
-    daysWithProblemSolving
+    teamWorkExperience
   )
 
   const multiplicator = getOverburdenMultiplicator(tasksInParallel)
@@ -51,14 +57,14 @@ export const getFeaturesForNextDay = ({
   initialStep,
   steps,
   strategy,
-  daysWithProblemSolving
+  teamWorkExperience
 }: {
   backlog: Feature[]
   features: Feature[]
   steps: FeatureStep[]
   initialStep: number
   strategy: Strategy | 'problem-solving'
-  daysWithProblemSolving: number
+  teamWorkExperience: number
 }): [Feature[], Feature[]] => {
   features
     .filter((feature) => feature.step > 0 || feature.status === 'doing')
@@ -107,7 +113,7 @@ export const getFeaturesForNextDay = ({
               tasksInParallel: features.filter(
                 (f) => f.status === 'doing' && f.step === feature.step
               ).length,
-              daysWithProblemSolving
+              teamWorkExperience
             })
           ) {
             feature.step = Math.min(4, feature.step + 1)
@@ -182,7 +188,7 @@ const getOverburdenMultiplicator = (tasksInParallel: number) => {
 
 const getQualityProbability = (
   complexity: number,
-  daysWithProblemSolving: number
+  teamWorkExperience: number
 ) => {
   let probabilityOfGoodQuality = 1
 
@@ -206,11 +212,14 @@ const getQualityProbability = (
 
   // team learning
   probabilityOfGoodQuality =
-    probabilityOfGoodQuality + (1.2 * daysWithProblemSolving) / 100
+    probabilityOfGoodQuality + (1.2 * teamWorkExperience) / 100
 
   return probabilityOfGoodQuality
 }
 
+const isFeatureDone = (feature: Feature) =>
+  feature.step === 0 && feature.status === 'done'
+
 export const nextDay = (
   state: FeatureState,
   strategy: Strategy | 'problem-solving'
@@ -218,7 +227,10 @@ export const nextDay = (
   state.meta.totalDays++
 
   if (strategy === 'problem-solving') {
-    state.meta.daysWithProblemSolving++
+    const hasTeamLearned = Math.random() > 0.25
+    if (hasTeamLearned) {
+      state.meta.teamWorkExperience++
+    }
   } else {
     state.meta.strategy[strategy]++
   }
@@ -229,16 +241,21 @@ export const nextDay = (
     steps: state.steps,
     initialStep: state.steps[0].stepIndex,
     strategy,
-    daysWithProblemSolving: state.meta.daysWithProblemSolving
+    teamWorkExperience: state.meta.teamWorkExperience
   })
   state.backlog = backlog
   state.features = features
 
+  const featuresDone = sumElements(state.meta.featuresDonePerDay) ?? 0
+  const featuresDoneNextDay = features.filter(isFeatureDone).length
+
+  state.meta.featuresDonePerDay.push(featuresDoneNextDay - featuresDone)
+
   return state
 }
 
 export const isProjectFinished = (features: Feature[]) =>
-  features.every((feature) => feature.step === 0 && feature.status === 'done')
+  features.every(isFeatureDone)
 
 export const getMeanComplexity = (features: Feature[]) => {
   return getMean(features.map((feature) => feature.complexity))
diff --git a/src/modules/feature/feature-store.ts b/src/modules/feature/feature-store.ts
index 0a943da..873310c 100644
--- a/src/modules/feature/feature-store.ts
+++ b/src/modules/feature/feature-store.ts
@@ -10,12 +10,13 @@ import {
 import { featureSteps } from '@/modules/feature/feature-steps'
 import { Strategy } from '@/modules/lean/strategy'
 import { FeatureState, Meta } from '@/store-type'
-import { clone } from '@/utils'
+import { sumElements } from '@/utils'
 import { defineStore } from 'pinia'
 
 const resetMeta = (): Meta => ({
   totalDays: 0,
-  daysWithProblemSolving: 0,
+  teamWorkExperience: 0,
+  featuresDonePerDay: [],
   strategy: {
     push: 0,
     pull: 0,
@@ -32,18 +33,19 @@ export const useFeatureStore = defineStore('feature', {
     meta: resetMeta()
   }),
   actions: {
+    // set the number of feature we want
     async initBoard() {
       this.backlog = newBacklog()
       this.steps = featureSteps
-      this.features = initBoard(clone(this.steps), clone(this.backlog))
+      this.features = initBoard(this.steps, this.backlog)
 
       this.backlog = this.backlog.filter(
         (l) => !this.features.find((f) => f.name === l.name)
       )
       this.meta = resetMeta()
     },
-    async nextDay(strategy: Strategy) {
-      const newState = nextDay(clone(this.$state), strategy)
+    async nextDay(strategy: Strategy | 'problem-solving') {
+      const newState = nextDay(this.$state, strategy)
 
       this.backlog = newState.backlog
       this.meta = newState.meta
@@ -54,6 +56,10 @@ export const useFeatureStore = defineStore('feature', {
     meanComplexity: (state) => getMeanComplexity(state.features),
     meanLeadTime: (state) => getMeanLeadTime(state.features),
     meanQualityIssue: (state) => getMeanQualityIssue(state.features),
+    taktTime: (state) =>
+      (
+        state.meta.totalDays / sumElements(state.meta.featuresDonePerDay)
+      ).toFixed(2) ?? 0,
     featuresGroupedByStep: (state) => {
       const groupedByStep: Record<number, Feature[]> = {}
 
diff --git a/src/modules/simulation/SimulationDashboard.vue b/src/modules/simulation/SimulationDashboard.vue
index 483fc65..c1080c0 100644
--- a/src/modules/simulation/SimulationDashboard.vue
+++ b/src/modules/simulation/SimulationDashboard.vue
@@ -1,7 +1,10 @@
 <script setup lang="ts">
+import { Strategy } from '@/modules/lean/strategy'
 import { useSimulationStore } from '@/modules/simulation/simulation-store'
 
 const simulationStore = useSimulationStore()
+
+const strategies: Strategy[] = ['push', 'pull', 'push-dps', 'pull-dps']
 </script>
 
 <template>
@@ -16,56 +19,35 @@ const simulationStore = useSimulationStore()
       <thead>
         <tr>
           <th>#</th>
-          <th>push</th>
-          <th>pull</th>
-          <th>pull and DPS</th>
-          <th>push and DPS</th>
+          <th class="numeric">push</th>
+          <th class="numeric">pull</th>
+          <th class="numeric">pull and DPS</th>
+          <th class="numeric">push and DPS</th>
         </tr>
       </thead>
       <tbody>
         <tr>
           <td>lead time</td>
-          <td class="numeric">
-            {{ simulationStore.meanPushLeadTime }}
+          <td class="numeric" v-for="strategy in strategies" :key="strategy">
+            {{ simulationStore.meanLeadTime(strategy) }}
           </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullLeadTime }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullDPSLeadTime }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPushDPSLeadTime }}
+        </tr>
+        <tr>
+          <td>takt time</td>
+          <td class="numeric" v-for="strategy in strategies" :key="strategy">
+            {{ simulationStore.meanTaktTime(strategy) }}
           </td>
         </tr>
         <tr>
           <td>Complexity</td>
-          <td class="numeric">
-            {{ simulationStore.meanPushComplexity }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullComplexity }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullDPSComplexity }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPushDPSComplexity }}
+          <td class="numeric" v-for="strategy in strategies" :key="strategy">
+            {{ simulationStore.meanComplexity(strategy) }}
           </td>
         </tr>
         <tr>
           <td>Quality issue</td>
-          <td class="numeric">
-            {{ simulationStore.meanPushQuality }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullQuality }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPullDPSQuality }}
-          </td>
-          <td class="numeric">
-            {{ simulationStore.meanPushDPSQuality }}
+          <td class="numeric" v-for="strategy in strategies" :key="strategy">
+            {{ simulationStore.meanQuality(strategy) }}
           </td>
         </tr>
       </tbody>
@@ -76,9 +58,13 @@ const simulationStore = useSimulationStore()
 <style scoped lang="scss">
 .simulation-dashboard {
   color: var(--primary-color);
+
+  table {
+    padding: 1rem;
+  }
 }
 
-td.numeric {
+.numeric {
   text-align: right;
 }
 </style>
diff --git a/src/modules/simulation/simulation-store.ts b/src/modules/simulation/simulation-store.ts
index a845991..261eb6d 100644
--- a/src/modules/simulation/simulation-store.ts
+++ b/src/modules/simulation/simulation-store.ts
@@ -1,13 +1,14 @@
 import { featureSteps } from '@/modules/feature/feature-steps'
 import { Strategy } from '@/modules/lean/strategy'
 import { Dashboard, Meta } from '@/store-type'
-import { getRound } from '@/utils'
+import { getRound, sumElements } from '@/utils'
 import { defineStore } from 'pinia'
 
 // Get features done per day to plot it
 
 type Mean = {
   leadTimeSum: number
+  taktTimeSum: number
   complexitySum: number
   qualityIssueSum: number
   simulations: number
@@ -22,6 +23,7 @@ type State = {
 
 const newMean = (): Mean => ({
   leadTimeSum: 0,
+  taktTimeSum: 0,
   complexitySum: 0,
   qualityIssueSum: 0,
   simulations: 0
@@ -33,7 +35,8 @@ const instance = new ComlinkWorker<typeof import('../feature/feature-board')>(
 
 const resetMeta = (): Meta => ({
   totalDays: 0,
-  daysWithProblemSolving: 0,
+  teamWorkExperience: 0,
+  featuresDonePerDay: [],
   strategy: {
     push: 0,
     pull: 0,
@@ -95,6 +98,10 @@ export const useSimulationStore = defineStore('dashboard', {
 
       this.newDashboard(dashboard)
       this.mean[strategy].leadTimeSum += dashboard.analysis.meanLeadTime
+      // todo: set directly the number of features
+      this.mean[strategy].taktTimeSum +=
+        dashboard.meta.totalDays /
+        sumElements(dashboard.meta.featuresDonePerDay)
       this.mean[strategy].complexitySum += dashboard.analysis.meanComplexity
       this.mean[strategy].qualityIssueSum += dashboard.analysis.meanQualityIssue
       this.mean[strategy].simulations++
@@ -115,71 +122,25 @@ export const useSimulationStore = defineStore('dashboard', {
     }
   },
   getters: {
-    meanPushLeadTime: (state) => {
-      return getRound(state.mean.push.leadTimeSum, state.mean.push.simulations)
-    },
-    meanPullLeadTime: (state) => {
-      return getRound(state.mean.pull.leadTimeSum, state.mean.pull.simulations)
-    },
-    meanPullDPSLeadTime: (state) => {
-      return getRound(
-        state.mean['pull-dps'].leadTimeSum,
-        state.mean['pull-dps'].simulations
+    meanLeadTime: (state) => (strategy: Strategy) =>
+      getRound(
+        state.mean[strategy].leadTimeSum,
+        state.mean[strategy].simulations
+      ),
+    meanTaktTime: (state) => (strategy: Strategy) =>
+      getRound(
+        state.mean[strategy].taktTimeSum,
+        state.mean[strategy].simulations
+      ),
+    meanComplexity: (state) => (strategy: Strategy) =>
+      getRound(
+        state.mean[strategy].complexitySum,
+        state.mean[strategy].simulations
+      ),
+    meanQuality: (state) => (strategy: Strategy) =>
+      getRound(
+        state.mean[strategy].qualityIssueSum,
+        state.mean[strategy].simulations
       )
-    },
-    meanPushDPSLeadTime: (state) => {
-      return getRound(
-        state.mean['push-dps'].leadTimeSum,
-        state.mean['push-dps'].simulations
-      )
-    },
-    meanPushComplexity: (state) => {
-      return getRound(
-        state.mean.push.complexitySum,
-        state.mean.push.simulations
-      )
-    },
-    meanPullComplexity: (state) => {
-      return getRound(
-        state.mean.pull.complexitySum,
-        state.mean.pull.simulations
-      )
-    },
-    meanPullDPSComplexity: (state) => {
-      return getRound(
-        state.mean['pull-dps'].complexitySum,
-        state.mean['pull-dps'].simulations
-      )
-    },
-    meanPushDPSComplexity: (state) => {
-      return getRound(
-        state.mean['push-dps'].complexitySum,
-        state.mean['push-dps'].simulations
-      )
-    },
-    meanPushQuality: (state) => {
-      return getRound(
-        state.mean.push.qualityIssueSum,
-        state.mean.push.simulations
-      )
-    },
-    meanPullQuality: (state) => {
-      return getRound(
-        state.mean.pull.qualityIssueSum,
-        state.mean.pull.simulations
-      )
-    },
-    meanPullDPSQuality: (state) => {
-      return getRound(
-        state.mean['pull-dps'].qualityIssueSum,
-        state.mean['pull-dps'].simulations
-      )
-    },
-    meanPushDPSQuality: (state) => {
-      return getRound(
-        state.mean['push-dps'].qualityIssueSum,
-        state.mean['push-dps'].simulations
-      )
-    }
   }
 })
diff --git a/src/store-type.ts b/src/store-type.ts
index a571603..70339c0 100644
--- a/src/store-type.ts
+++ b/src/store-type.ts
@@ -4,8 +4,9 @@ import { Strategy } from '@/modules/lean/strategy'
 
 export type Meta = {
   totalDays: number
-  daysWithProblemSolving: number
+  teamWorkExperience: number
   strategy: Record<Strategy, number>
+  featuresDonePerDay: number[]
 }
 
 export type Analysis = {