From 8654cd1dbe4ce3af22a8969e776a0dcb1a99be17 Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Mon, 31 Jul 2023 23:18:43 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20(pull=20system)=20fix=20pull=20s?=
 =?UTF-8?q?ystems?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../article/FlowMultipleSimulation.vue        |  5 ++-
 src/modules/feature/feature-board.ts          | 31 +++++++------------
 2 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/src/modules/article/FlowMultipleSimulation.vue b/src/modules/article/FlowMultipleSimulation.vue
index d5767b5..c8a6e3e 100644
--- a/src/modules/article/FlowMultipleSimulation.vue
+++ b/src/modules/article/FlowMultipleSimulation.vue
@@ -1,6 +1,9 @@
 <template>
   <div class="flow-conclusion">
-    <p>Teams tend to underestimate how long a project will be.</p>
+    <p>
+      Teams tend to underestimate how long a project will be. And how hard it
+      will be to work with others.
+    </p>
     <p>
       If we're not in a good pace, we just have to try harder. Only once. "Just
       in time" becomes "Just this time". So teams overproduce. Creating stock
diff --git a/src/modules/feature/feature-board.ts b/src/modules/feature/feature-board.ts
index c5f57b7..400f7c5 100644
--- a/src/modules/feature/feature-board.ts
+++ b/src/modules/feature/feature-board.ts
@@ -14,7 +14,7 @@ import {
 
 const HARD_STOP = 5000
 
-const hasQualityIssue = ({
+const getQualityIssue = ({
   complexity,
   tasksInParallel,
   teamWorkExperience
@@ -71,6 +71,7 @@ export const getFeaturesForNextDay = ({
 }): [Feature[], Feature[]] => {
   features
     .filter((feature) => feature.step > 0 || feature.status === 'doing')
+    .sort((a, b) => (a.step < b.step ? -1 : 1))
     .forEach((feature) => {
       feature.leadTime++
 
@@ -94,9 +95,7 @@ export const getFeaturesForNextDay = ({
 
             const hasBlueBinAvailableNextStep =
               nextStep.blueBins -
-                features.filter(
-                  (f) => f.step === feature.step - 1 && f.status === 'done'
-                ).length >
+                features.filter((f) => f.step === feature.step - 1).length >
               0
 
             if (hasBlueBinAvailableNextStep) {
@@ -110,15 +109,15 @@ export const getFeaturesForNextDay = ({
             break
           }
 
-          if (
-            hasQualityIssue({
-              complexity: feature.complexity,
-              tasksInParallel: features.filter(
-                (f) => f.status === 'doing' && f.step === feature.step
-              ).length,
-              teamWorkExperience
-            })
-          ) {
+          const hasQualityIssue = getQualityIssue({
+            complexity: feature.complexity,
+            tasksInParallel: features.filter(
+              (f) => f.status === 'doing' && f.step === feature.step
+            ).length,
+            teamWorkExperience
+          })
+
+          if (hasQualityIssue) {
             feature.qualityIssue++
           } else {
             feature.step--
@@ -177,12 +176,6 @@ const getOverburdenMultiplicator = (tasksInParallel: number) => {
       return 8
     case 5:
       return 13
-    // case 6:
-    //   return 4
-    // case 7:
-    //   return 5.5
-    // case 8:
-    //   return 7
     default:
       return 25
   }