From 76540f5a5af0a74f6a6a3cf09be2c38f46e6a33c Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Tue, 31 Dec 2024 10:14:00 +0100
Subject: [PATCH] fix: eraser not resetting features

---
 src/modules/pull-system/article/FlowSetup.vue |  6 +++---
 .../pull-system/feature/FlowControls.vue      | 20 ++++---------------
 .../pull-system/feature/feature-board.ts      |  4 +++-
 .../pull-system/feature/feature.fixture.ts    | 20 ++++++++++---------
 src/store-type.ts                             |  6 +++---
 5 files changed, 24 insertions(+), 32 deletions(-)

diff --git a/src/modules/pull-system/article/FlowSetup.vue b/src/modules/pull-system/article/FlowSetup.vue
index 7fa61d1..b10b67b 100644
--- a/src/modules/pull-system/article/FlowSetup.vue
+++ b/src/modules/pull-system/article/FlowSetup.vue
@@ -57,16 +57,16 @@ const feature: Feature = {
     <p>Each day, you can choose between 3 strategies:</p>
     <ol>
       <li>
-        Push system
         <PushSystemIcon />
+        Push system
       </li>
       <li>
-        Pull system
         <PullSystemIcon />
+        Pull system
       </li>
       <li>
-        Problem solving
         <ProblemSolvingIcon />
+        Problem solving
       </li>
     </ol>
     <p>
diff --git a/src/modules/pull-system/feature/FlowControls.vue b/src/modules/pull-system/feature/FlowControls.vue
index d144823..13fbd87 100644
--- a/src/modules/pull-system/feature/FlowControls.vue
+++ b/src/modules/pull-system/feature/FlowControls.vue
@@ -15,28 +15,16 @@ const featureStore = useFeatureStore()
 <template>
   <div class="flow-controls">
     <div class="row">
-      <button
-        @click="featureStore.nextDay('push')"
-        :disabled="featureStore.isProjectFinished"
-      >
+      <button @click="featureStore.nextDay('push')" :disabled="featureStore.isProjectFinished">
         <PushSystemIcon color="white" />
       </button>
-      <button
-        @click="featureStore.nextDay('pull')"
-        :disabled="featureStore.isProjectFinished"
-      >
+      <button @click="featureStore.nextDay('pull')" :disabled="featureStore.isProjectFinished">
         <PullSystemIcon color="white" />
       </button>
-      <button
-        @click="featureStore.nextDay('problem-solving')"
-        :disabled="featureStore.isProjectFinished"
-      >
+      <button @click="featureStore.nextDay('problem-solving')" :disabled="featureStore.isProjectFinished">
         <ProblemSolvingIcon color="white" />
       </button>
-      <button
-        v-if="withEraser"
-        @click="featureStore.initBoard(NUMBER_OF_FEATURES)"
-      >
+      <button v-if="withEraser" @click="featureStore.initBoard('mobile-app', NUMBER_OF_FEATURES)">
         <EraserIcon color="white" />
       </button>
     </div>
diff --git a/src/modules/pull-system/feature/feature-board.ts b/src/modules/pull-system/feature/feature-board.ts
index 7e2c819..72e1b51 100644
--- a/src/modules/pull-system/feature/feature-board.ts
+++ b/src/modules/pull-system/feature/feature-board.ts
@@ -1,3 +1,4 @@
+import { newsAppFeatures } from '@/data/app-feature'
 import type {
   Feature,
   FeatureStatus
@@ -74,7 +75,8 @@ const mayBeInProgress = ({
 }
 
 export const newBacklog = (type: 'bird' | 'mobile-app', limit?: number) => {
-  const initialFeatures = type === 'bird' ? birdFeatures : mobileAppFeatures
+  const initialFeatures =
+    type === 'bird' ? [...birdFeatures] : [...mobileAppFeatures]
   return limit !== undefined
     ? popNElement(shuffleArray(initialFeatures), limit)
     : shuffleArray(initialFeatures)
diff --git a/src/modules/pull-system/feature/feature.fixture.ts b/src/modules/pull-system/feature/feature.fixture.ts
index 98e578d..e96cc6a 100644
--- a/src/modules/pull-system/feature/feature.fixture.ts
+++ b/src/modules/pull-system/feature/feature.fixture.ts
@@ -12,7 +12,7 @@ export const features: Feature[] = birds.map((name) => ({
   qualityIssue: 0
 }))
 
-export const birdFeatures: Feature[] = birds.map((name) => ({
+export const birdFeatures: readonly Feature[] = birds.map((name) => ({
   name,
   complexity: randomInteger(1, 5),
   leadTime: 0,
@@ -21,11 +21,13 @@ export const birdFeatures: Feature[] = birds.map((name) => ({
   qualityIssue: 0
 }))
 
-export const mobileAppFeatures: Feature[] = newsAppFeatures.map((name) => ({
-  name,
-  complexity: randomInteger(1, 5),
-  leadTime: 0,
-  status: 'doing',
-  step: Infinity,
-  qualityIssue: 0
-}))
+export const mobileAppFeatures: readonly Feature[] = newsAppFeatures.map(
+  (name) => ({
+    name,
+    complexity: randomInteger(1, 5),
+    leadTime: 0,
+    status: 'doing',
+    step: Infinity,
+    qualityIssue: 0
+  })
+)
diff --git a/src/store-type.ts b/src/store-type.ts
index 86aec69..7c56876 100644
--- a/src/store-type.ts
+++ b/src/store-type.ts
@@ -1,6 +1,6 @@
-import { Feature } from '@/modules/pull-system/feature/feature'
-import { FeatureStep } from '@/modules/pull-system/feature/feature-steps'
-import { Strategy } from '@/modules/lean/strategy'
+import type { Feature } from '@/modules/pull-system/feature/feature'
+import type { FeatureStep } from '@/modules/pull-system/feature/feature-steps'
+import type { Strategy } from '@/modules/pull-system/lean/strategy'
 
 export type Meta = {
   totalDays: number