From 4c24c176f1a2287924cb7ae9816843e0bf4439e9 Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Sun, 30 Jul 2023 01:58:15 +0200
Subject: [PATCH] display chart only when simulations finished

---
 src/modules/simulation/SimulationChart.vue    | 42 +++++++++++++------
 src/modules/simulation/SimulationControls.vue |  2 +-
 src/modules/simulation/simulation-store.ts    |  5 ++-
 3 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/src/modules/simulation/SimulationChart.vue b/src/modules/simulation/SimulationChart.vue
index 97739f9..ab56695 100644
--- a/src/modules/simulation/SimulationChart.vue
+++ b/src/modules/simulation/SimulationChart.vue
@@ -1,53 +1,61 @@
 <script setup lang="ts">
 import { useSimulationStore } from '@/modules/simulation/simulation-store'
+import { popNElement } from '@/utils'
 import chartXkcd from 'chart.xkcd'
-import { onMounted } from 'vue'
+import { onMounted, ref, watch } from 'vue'
 
 const simulationStore = useSimulationStore()
+const SAMPLE = 15
+const isChartInit = ref(false)
 
 const reloadGraph = () => {
-  if (
-    simulationStore.dashboards.length === 0 ||
-    simulationStore.dashboards.length > 15
-  ) {
+  if (simulationStore.dashboards.length === 0) {
     return
   }
+  isChartInit.value = true
 
-  const svg = document.querySelector('.chart')
+  const samples = popNElement(
+    [...simulationStore.dashboards],
+    SAMPLE
+  ).toReversed()
+
+  const svg = document.querySelector('svg.chart')
   const config = {
-    title: 'Features done per day',
+    title: `${SAMPLE} simulations`,
     xLabel: 'days',
     yLabel: 'features done',
     data: {
       labels: Array.from(
         {
           length: Math.max(
-            ...simulationStore.dashboards.map(
-              (dashboard) => dashboard.meta.totalDays
-            )
+            ...samples.map((dashboard) => dashboard.meta.totalDays)
           )
         },
         (_, index) => index + 1
       ),
-      datasets: simulationStore.dashboards.map((dashboard, index) => ({
+      datasets: samples.map((dashboard, index) => ({
         label: `${dashboard.analysis.strategy} ${index + 1}`,
         data: dashboard.meta.featuresDonePerDay
       }))
     },
     options: {
-      showLegend: false
+      showLegend: false,
+      fontFamily: 'Noto Serif'
     }
   }
   new chartXkcd.Line(svg, config)
 }
 
-// watch(simulationStore.dashboards, reloadGraph)
+watch(() => simulationStore.hasSimulationFinished, reloadGraph)
 onMounted(reloadGraph)
 </script>
 
 <template>
   <div class="simulation-chart">
     <svg class="chart"></svg>
+    <div v-if="!isChartInit" class="chart no-init">
+      Chart appears once every simulations resume
+    </div>
   </div>
 </template>
 
@@ -56,4 +64,12 @@ onMounted(reloadGraph)
   width: 80vw;
   height: 100vh;
 }
+
+.no-init {
+  position: relative;
+  top: -100vh;
+  display: flex;
+  justify-content: center;
+  align-items: center;
+}
 </style>
diff --git a/src/modules/simulation/SimulationControls.vue b/src/modules/simulation/SimulationControls.vue
index 2856d81..ef30b6f 100644
--- a/src/modules/simulation/SimulationControls.vue
+++ b/src/modules/simulation/SimulationControls.vue
@@ -2,7 +2,7 @@
 import { Strategy } from '@/modules/lean/strategy'
 import { useSimulationStore } from '@/modules/simulation/simulation-store'
 const simulationStore = useSimulationStore()
-const NUMBER_OF_SIMULATION = 400
+const NUMBER_OF_SIMULATION = 200
 
 const strategies: Strategy[] = ['push', 'pull', 'push-dps', 'pull-dps']
 
diff --git a/src/modules/simulation/simulation-store.ts b/src/modules/simulation/simulation-store.ts
index d295c4e..a1068e6 100644
--- a/src/modules/simulation/simulation-store.ts
+++ b/src/modules/simulation/simulation-store.ts
@@ -154,6 +154,9 @@ export const useSimulationStore = defineStore('dashboard', {
       getRound(
         state.mean[strategy].totalDaysSum,
         state.mean[strategy].simulations
-      )
+      ),
+    hasSimulationFinished: (state) =>
+      state.requestedSimulation > 0 &&
+      state.requestedSimulation === state.simulationsDone
   }
 })