From f276a1cb5bde517dae4d6c6284cf9c4dc50274cd Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Sat, 20 May 2023 13:03:51 +0200
Subject: [PATCH] extract record resume in its own component

---
 .../record/components/RecordResume.vue        | 39 +++++++++++++++++++
 src/modules/record/components/TaskRecord.vue  | 27 +++----------
 .../record/hooks/useTaskRecordMetadata.ts     |  4 +-
 3 files changed, 47 insertions(+), 23 deletions(-)
 create mode 100644 src/modules/record/components/RecordResume.vue

diff --git a/src/modules/record/components/RecordResume.vue b/src/modules/record/components/RecordResume.vue
new file mode 100644
index 0000000..79a3f97
--- /dev/null
+++ b/src/modules/record/components/RecordResume.vue
@@ -0,0 +1,39 @@
+<script setup lang="ts">
+import { useTaskRecordMetadata } from '@/modules/record/hooks/useTaskRecordMetadata'
+import type { Recordable } from '@/modules/record/interfaces/recordable'
+import { computed } from 'vue'
+
+const props = defineProps<{
+  record: Recordable
+  totalEstimation: number
+}>()
+
+const { duration } = useTaskRecordMetadata(props.record)
+
+const isSuperiorToEstimation = computed(() => {
+  if (!duration.value) {
+    return false
+  }
+
+  return duration.value > props.totalEstimation
+})
+</script>
+
+<template>
+  <div class="record-resume content" v-if="record.end">
+    <p
+      :class="{
+        'has-text-primary-dark': !isSuperiorToEstimation,
+        'has-text-warning-dark': isSuperiorToEstimation
+      }"
+    >
+      The task took {{ duration }} minutes instead of
+      {{ totalEstimation }} minutes.
+    </p>
+  </div>
+</template>
+
+<style scoped lang="scss">
+.record-resume {
+}
+</style>
diff --git a/src/modules/record/components/TaskRecord.vue b/src/modules/record/components/TaskRecord.vue
index dc9e652..66e018f 100644
--- a/src/modules/record/components/TaskRecord.vue
+++ b/src/modules/record/components/TaskRecord.vue
@@ -1,11 +1,11 @@
 <script setup lang="ts">
 import EstimationTimeArrival from '@/components/EstimationTimeArrival.vue'
+import RecordResume from '@/modules/record/components/RecordResume.vue'
 import { useTaskStore } from '@/modules/task/stores/useTask.store'
 import { formatLongDate } from '@/shared/format-date'
 import { useLoopyTitle } from '@/shared/useLoopyTitle'
 import { computed } from 'vue'
 import { useRouter } from 'vue-router'
-import { useTaskRecordMetadata } from '../hooks/useTaskRecordMetadata'
 import { useTaskRecordStore } from '../stores/useTaskRecordStore'
 import RecordControls from './RecordControls.vue'
 import RecordProgress from './RecordProgress.vue'
@@ -30,15 +30,6 @@ useLoopyTitle(task.value?.title ?? '')
 
 const record = computed(() => recordStore.getTaskRecord(props.taskId))
 const recordNotes = computed(() => recordStore.getRecordNotes(props.taskId))
-const { duration } = useTaskRecordMetadata(record)
-
-const isSuperiorToEstimation = computed(() => {
-  if (!task.value || !record.value || !duration.value) {
-    return false
-  }
-
-  return duration.value > task.value.totalEstimation
-})
 </script>
 
 <template>
@@ -75,17 +66,11 @@ const isSuperiorToEstimation = computed(() => {
         />
       </tbody>
     </table>
-    <div v-show="record && record.end" class="content">
-      <p
-        :class="{
-          'has-text-primary-dark': !isSuperiorToEstimation,
-          'has-text-warning-dark': isSuperiorToEstimation
-        }"
-      >
-        The task took {{ duration }} minutes instead of
-        {{ task.totalEstimation }} minutes.
-      </p>
-    </div>
+    <record-resume
+      v-if="record"
+      :record="record"
+      :total-estimation="task.totalEstimation"
+    />
     <div class="columns is-centered">
       <div class="column is-half">
         <textarea
diff --git a/src/modules/record/hooks/useTaskRecordMetadata.ts b/src/modules/record/hooks/useTaskRecordMetadata.ts
index 9e82390..b1adae4 100644
--- a/src/modules/record/hooks/useTaskRecordMetadata.ts
+++ b/src/modules/record/hooks/useTaskRecordMetadata.ts
@@ -1,9 +1,9 @@
+import type { Recordable } from '@/modules/record/interfaces/recordable'
 import { formatDiffInMinutes } from '@/shared/format-date'
 import { computed, isRef, type Ref } from 'vue'
-import type { TaskRecord } from '../models/task-record'
 
 export const useTaskRecordMetadata = (
-  record: TaskRecord | Ref<TaskRecord | null>
+  record: Recordable | Ref<Recordable | null>
 ) => {
   const taskDurations = computed(() => {
     const recordValue = isRef(record) ? record.value : record