refactor: 💡 fixtures

change naming convention for fixture methods
This commit is contained in:
Julien Calixte
2023-05-01 19:11:38 +02:00
parent c51acf1aae
commit 765b130e54
12 changed files with 38 additions and 47 deletions

View File

@@ -1,17 +1,17 @@
import { createTaskFixture } from '@/modules/task/models/task.fixture'
import { fixtureTask } from '@/modules/task/models/task.fixture'
import { router } from '@/router'
import { toISODate } from '@/shared/types/date'
import { withPlugins } from '@/tests/utils'
import { faker } from '@faker-js/faker'
import { mount } from '@vue/test-utils'
import { describe, expect, it, vi } from 'vitest'
import { createRecordableFixture } from '../interfaces/recordable.fixture'
import { fixtureRecordable } from '../interfaces/recordable.fixture'
import TaskRecordPreview from './TaskRecordPreview.vue'
const mountTaskRecordPreview = (withRecord = false) => {
const task = createTaskFixture()
const task = fixtureTask()
const end = toISODate(new Date('2023-04-17T20:00:00.000Z'))
const record = createRecordableFixture({
const record = fixtureRecordable({
taskId: task.id,
stepRecords: {
[faker.datatype.uuid()]: {

View File

@@ -2,7 +2,7 @@ import { toISODate } from '@/shared/types/date'
import { faker } from '@faker-js/faker'
import { describe, expect, it } from 'vitest'
import { ref } from 'vue'
import { createRecordableFixture } from '../interfaces/recordable.fixture'
import { fixtureRecordable } from '../interfaces/recordable.fixture'
import { TaskRecord } from '../models/task-record'
import { useTaskRecordMetadata } from './useTaskRecordMetadata'
@@ -15,7 +15,7 @@ describe('use task record metadata', () => {
it('returns the right duration', () => {
const end = toISODate(new Date('2023-04-17T20:00:00.000Z'))
const record = createRecordableFixture({
const record = fixtureRecordable({
stepRecords: {
[faker.datatype.uuid()]: {
start: toISODate(new Date('2023-04-17T19:00:00.000Z')),

View File

@@ -2,7 +2,7 @@ import { toISODate } from '@/shared/types/date'
import { faker } from '@faker-js/faker'
import type { Recordable } from './recordable'
export const createRecordableFixture = (
export const fixtureRecordable = (
partialRecordable?: Partial<Recordable>
): Recordable => ({
taskId: partialRecordable?.taskId ?? faker.datatype.uuid(),

View File

@@ -2,7 +2,7 @@ import { toISODate } from '@/shared/types/date'
import { faker } from '@faker-js/faker'
import type { TimeRange } from './time-range'
export const createTimeRangeFixture = (
export const fixtureTimeRange = (
partialTimeRange?: Partial<TimeRange>
): TimeRange => {
const [start, end] = faker.date.betweens(

View File

@@ -2,7 +2,7 @@ import { toISODate } from '@/shared/types/date'
import { faker } from '@faker-js/faker'
import { describe, expect, it } from 'vitest'
import type { Recordable } from '../interfaces/recordable'
import { createTimeRangeFixture } from '../interfaces/time-range.fixture'
import { fixtureTimeRange } from '../interfaces/time-range.fixture'
import { TaskRecord } from './task-record'
describe('Task Record', () => {
@@ -12,9 +12,9 @@ describe('Task Record', () => {
notes: faker.lorem.paragraphs(),
start: toISODate(faker.date.past(1)),
end: toISODate(faker.date.past()),
breakTime: createTimeRangeFixture(),
breakTime: fixtureTimeRange(),
stepRecords: {
[faker.datatype.uuid()]: createTimeRangeFixture()
[faker.datatype.uuid()]: fixtureTimeRange()
}
}

View File

@@ -1,11 +1,11 @@
import { toISODate } from '@/shared/types/date'
import { describe, expect, it } from 'vitest'
import { createRecordableFixture } from '../interfaces/recordable.fixture'
import { fixtureRecordable } from '../interfaces/recordable.fixture'
import { addBreakTimeToStepRecords } from './breaktime-service'
describe('Break Time Service', () => {
it('adds no break time if there is no break time', () => {
const record = createRecordableFixture({
const record = fixtureRecordable({
breakTime: undefined
})
@@ -13,7 +13,7 @@ describe('Break Time Service', () => {
})
it('adds no break time if the break is not over yet', () => {
const record = createRecordableFixture({
const record = fixtureRecordable({
breakTime: {
start: toISODate(new Date('2023-04-17T19:00:00.000Z'))
},
@@ -28,7 +28,7 @@ describe('Break Time Service', () => {
})
it('adds break time if break time is over', () => {
const record = createRecordableFixture({
const record = fixtureRecordable({
breakTime: {
start: toISODate(new Date('2023-04-17T19:00:00.000Z')),
end: toISODate(new Date('2023-04-17T20:00:00.000Z'))
@@ -51,7 +51,7 @@ describe('Break Time Service', () => {
})
it('adds break time only for unfinished step records', () => {
const record = createRecordableFixture({
const record = fixtureRecordable({
breakTime: {
start: toISODate(new Date('2023-04-17T19:00:00.000Z')),
end: toISODate(new Date('2023-04-17T20:00:00.000Z'))