From 5d936476d0bce2ab614b866556ea50cb520b81af Mon Sep 17 00:00:00 2001 From: Julien Calixte Date: Sat, 20 May 2023 12:51:05 +0200 Subject: [PATCH] remove unecessary hasSteps --- src/modules/record/models/task-record.test.ts | 18 ------------------ src/modules/record/models/task-record.ts | 4 ---- 2 files changed, 22 deletions(-) diff --git a/src/modules/record/models/task-record.test.ts b/src/modules/record/models/task-record.test.ts index af2e373..d3046d5 100644 --- a/src/modules/record/models/task-record.test.ts +++ b/src/modules/record/models/task-record.test.ts @@ -21,22 +21,4 @@ describe('Task Record', () => { expect(TaskRecord.fromRecordable(recordable)).toEqual(recordable) }) - - it('tells if there are steps in the record', () => { - const record = fixtureRecordable({ - stepRecords: { - [faker.datatype.uuid()]: fixtureTimeRange() - } - }) - - expect(TaskRecord.fromRecordable(record).hasStepRecords).toBe(true) - }) - - it('tells if there are no steps in the record', () => { - const record = fixtureRecordable({ - stepRecords: {} - }) - - expect(TaskRecord.fromRecordable(record).hasStepRecords).toBe(false) - }) }) diff --git a/src/modules/record/models/task-record.ts b/src/modules/record/models/task-record.ts index e2607cf..4252859 100644 --- a/src/modules/record/models/task-record.ts +++ b/src/modules/record/models/task-record.ts @@ -12,10 +12,6 @@ export class TaskRecord implements Recordable { public constructor(public readonly taskId: string) {} - public get hasStepRecords() { - return Object.values(this.stepRecords).length > 0 - } - public static fromRecordable(recordable: Recordable) { const taskRecord = new TaskRecord(recordable.taskId)