From 266be28809509bfd980b2ecacbf74f43b626efd3 Mon Sep 17 00:00:00 2001
From: Julien Calixte <julienc@bam.tech>
Date: Mon, 10 Apr 2023 21:51:57 +0200
Subject: [PATCH] a message when finished and access to old records

---
 src/modules/record/components/StepRecord.vue  |  6 +-
 src/modules/record/components/TaskRecord.vue  | 58 +++++++++++++------
 .../record/components/TaskRecordList.vue      | 13 ++++-
 src/modules/record/interfaces/recordable.ts   |  4 --
 src/modules/record/models/task-record.ts      |  9 ---
 src/shared/format-date.ts                     |  1 +
 src/views/task/TaskView.vue                   |  1 +
 7 files changed, 57 insertions(+), 35 deletions(-)

diff --git a/src/modules/record/components/StepRecord.vue b/src/modules/record/components/StepRecord.vue
index 953d947..56a43f7 100644
--- a/src/modules/record/components/StepRecord.vue
+++ b/src/modules/record/components/StepRecord.vue
@@ -34,7 +34,6 @@ const duration = computed(() => {
     return null
   }
 
-  // TODO: diff in minutes not in seconds
   return formatDiffInMinutes(
     stepRecord.value.start,
     stepRecord.value?.end ?? now.value
@@ -59,11 +58,14 @@ const isSuperiorToEstimation = computed(() => {
       <span v-if="isSuperiorToEstimation">⚠️</span>
       {{ duration }} minutes
     </td>
-    <td v-else>NA</td>
+    <td v-else></td>
   </tr>
 </template>
 
 <style scoped lang="scss">
 .step-record {
+  &.current {
+    background-color: rgb(4, 62, 62);
+  }
 }
 </style>
diff --git a/src/modules/record/components/TaskRecord.vue b/src/modules/record/components/TaskRecord.vue
index 5416a78..392b0e8 100644
--- a/src/modules/record/components/TaskRecord.vue
+++ b/src/modules/record/components/TaskRecord.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import { useTaskStore } from '@/modules/task/stores/useTask.store'
-import { formatDate } from '@/shared/format-date'
+import { formatDate, formatDiffInMinutes } from '@/shared/format-date'
 import { toISODate } from '@/shared/types/date'
 import { computed } from 'vue'
 import { useTaskRecordStore } from '../stores/useTaskRecordStore'
@@ -68,25 +68,44 @@ const nextStep = () => {
     tick: toISODate(new Date())
   })
 }
+
+const duration = computed(() => {
+  if (!record.value?.end) {
+    return null
+  }
+
+  return formatDiffInMinutes(record.value.start, record.value?.end)
+})
+
+const isSuperiorToEstimation = computed(() => {
+  if (!task.value || !record.value || !duration.value) {
+    return false
+  }
+
+  return duration.value > task.value.totalEstimation
+})
 </script>
 
 <template>
-  <div class="task-record" v-if="task">
+  <main class="task-record" v-if="task">
     <h1>Task: {{ task.title }}</h1>
     <h2>start time: {{ formatDate(record.start) }}</h2>
-    <button
-      v-if="!recordStore.currentStepId && !record.hasStepRecords"
-      @click="startRecording"
-    >
-      start
-    </button>
-    <button v-else @click="nextStep">next</button>
+    <template v-if="!record.end">
+      <button
+        v-if="!recordStore.currentStepId && !record.hasStepRecords"
+        @click="startRecording"
+      >
+        start
+      </button>
+      <button v-else @click="nextStep">next</button>
+    </template>
+
     <button @click="recordStore.$reset">reset</button>
     <table>
       <thead>
         <tr>
           <th>#</th>
-          <th>Task</th>
+          <th>task</th>
           <th>estimation</th>
           <th>actual</th>
         </tr>
@@ -102,17 +121,22 @@ const nextStep = () => {
         />
       </tbody>
     </table>
-  </div>
+    <div v-if="record.end">
+      <hr />
+      The task took {{ duration }} minutes instead of
+      {{ task.totalEstimation }} minutes.
+      <span>
+        <span v-if="isSuperiorToEstimation">More</span><span v-else>Less</span>
+        than expected.
+      </span>
+    </div>
+  </main>
 </template>
 
 <style scoped lang="scss">
 .task-record {
-  .current {
-    background-color: red;
-  }
-
-  .estimation {
-    font-style: italic;
+  table {
+    width: 100%;
   }
 }
 </style>
diff --git a/src/modules/record/components/TaskRecordList.vue b/src/modules/record/components/TaskRecordList.vue
index 762a3d8..7222141 100644
--- a/src/modules/record/components/TaskRecordList.vue
+++ b/src/modules/record/components/TaskRecordList.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import { createUuid } from '@/shared/create-uuid'
+import { formatDate } from '@/shared/format-date'
 import { useTaskRecordStore } from '../stores/useTaskRecordStore'
 
 const props = defineProps<{
@@ -13,11 +14,17 @@ const newRecordId = createUuid()
 </script>
 
 <template>
-  <ul v-if="records.length" class="task-record-list">
+  <ol v-if="records.length" class="task-record-list">
     <li v-for="record in records" :key="record.id">
-      {{ record }}
+      <router-link
+        :to="{
+          name: 'record-view',
+          params: { taskId, recordId: record.id }
+        }"
+        >{{ formatDate(record.start) }}</router-link
+      >
     </li>
-  </ul>
+  </ol>
   <div v-else>No record yet</div>
   <router-link
     :to="{
diff --git a/src/modules/record/interfaces/recordable.ts b/src/modules/record/interfaces/recordable.ts
index c630420..38029ca 100644
--- a/src/modules/record/interfaces/recordable.ts
+++ b/src/modules/record/interfaces/recordable.ts
@@ -9,10 +9,6 @@ export interface Recordable {
    * TODO: Compute this data from step records
    */
   start: ISODate
-  /**
-   * @deprecated
-   * TODO: Compute this data from step records
-   */
   end?: ISODate
   stepRecords: Record<string, StepRecordable>
 }
diff --git a/src/modules/record/models/task-record.ts b/src/modules/record/models/task-record.ts
index e793708..663a76f 100644
--- a/src/modules/record/models/task-record.ts
+++ b/src/modules/record/models/task-record.ts
@@ -1,4 +1,3 @@
-import { formatDiffInMinutes } from '@/shared/format-date'
 import { toISODate, type ISODate } from '@/shared/types/date'
 import type { Recordable } from '../interfaces/recordable'
 import type { StepRecordable } from '../interfaces/step-recordable'
@@ -13,14 +12,6 @@ export class TaskRecord implements Recordable {
     public readonly taskId: string
   ) {}
 
-  public get duration(): number | null {
-    if (!this.end) {
-      return null
-    }
-
-    return formatDiffInMinutes(this.start, this.end)
-  }
-
   public get hasStepRecords() {
     return Object.values(this.stepRecords).length > 0
   }
diff --git a/src/shared/format-date.ts b/src/shared/format-date.ts
index fe05a6e..d14785e 100644
--- a/src/shared/format-date.ts
+++ b/src/shared/format-date.ts
@@ -5,5 +5,6 @@ export const formatDate = (date: Date | string) =>
 
 export const formatDiffInMinutes = (date1: ISODate, date2: ISODate) => {
   const diffInMs = new Date(date2).getTime() - new Date(date1).getTime()
+  // TODO: diff in minutes not in seconds
   return Math.max(0, Math.round(diffInMs / 1000))
 }
diff --git a/src/views/task/TaskView.vue b/src/views/task/TaskView.vue
index 9bb1a1c..9c44be8 100644
--- a/src/views/task/TaskView.vue
+++ b/src/views/task/TaskView.vue
@@ -28,6 +28,7 @@ const task = computed(() => taskStore.getTask(props.id))
         <div>{{ step.title }} | {{ step.estimation }}</div>
       </li>
     </ul>
+    <hr />
     <task-record-list :task-id="id" />
   </div>
   <div v-else>Task not found</div>